From 826ec4a8e61a2c3a1a9400cc93e2d4e8ae2bc448 Mon Sep 17 00:00:00 2001 From: Daniel Friesel Date: Wed, 29 Jun 2011 12:36:50 +0200 Subject: Minor code style adjustment (no parens after accessors) --- bin/efa | 6 +++--- lib/Travel/Routing/DE/VRR.pm | 12 ++++++------ lib/Travel/Routing/DE/VRR/Route.pm | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/bin/efa b/bin/efa index f073712..08bdc8c 100755 --- a/bin/efa +++ b/bin/efa @@ -185,12 +185,12 @@ $efa = eval { check_for_error($@); -my @routes = $efa->routes(); +my @routes = $efa->routes; for my $i ( 0 .. $#routes ) { - for my $c ( $routes[$i]->parts() ) { + for my $c ( $routes[$i]->parts ) { - for my $extra ( $c->extra() ) { + for my $extra ( $c->extra ) { if ( not( length $ignore_info and $extra =~ /$ignore_info/i ) ) { say "# $extra"; diff --git a/lib/Travel/Routing/DE/VRR.pm b/lib/Travel/Routing/DE/VRR.pm index be0d76a..8f45fa0 100644 --- a/lib/Travel/Routing/DE/VRR.pm +++ b/lib/Travel/Routing/DE/VRR.pm @@ -397,7 +397,7 @@ sub parse_initial { } if ( $colspan == 8 ) { - if ( $td->textContent() =~ m{ (? \d+ ) [.] .+ Fahrt }x ) { + if ( $td->textContent =~ m{ (? \d+ ) [.] .+ Fahrt }x ) { $con_no = $+{no} - 1; $con_part = 0; next; @@ -415,9 +415,9 @@ sub parse_initial { if ( defined $con_no and not $td->exists($xp_img) - and $td->textContent() !~ /^\s*$/ ) + and $td->textContent !~ /^\s*$/ ) { - push( @{ $cons->[$con_no]->[$con_part] }, $td->textContent() ); + push( @{ $cons->[$con_no]->[$con_part] }, $td->textContent ); } } @@ -530,7 +530,7 @@ sub submit { sub parse { my ($self) = @_; - my $raw_cons = $self->parse_initial(); + my $raw_cons = $self->parse_initial; for my $raw_con ( @{$raw_cons} ) { push( @{ $self->{routes} }, $self->parse_pretty($raw_con) ); @@ -559,7 +559,7 @@ sub check_ambiguous { my @possible; foreach my $val ( $select->findnodes($xp_option) ) { - push( @possible, $val->textContent() ); + push( @possible, $val->textContent ); } my $err_text = join( q{, }, @possible ); @@ -582,7 +582,7 @@ sub check_no_connections { my $err_node = $tree->findnodes($xp_err_img)->[0]; if ($err_node) { - my $text = $err_node->parentNode()->parentNode()->textContent(); + my $text = $err_node->parentNode->parentNode->textContent; Travel::Routing::DE::VRR::Exception::NoConnections->throw( error => $text, ); } diff --git a/lib/Travel/Routing/DE/VRR/Route.pm b/lib/Travel/Routing/DE/VRR/Route.pm index 6593a23..dc8ae55 100644 --- a/lib/Travel/Routing/DE/VRR/Route.pm +++ b/lib/Travel/Routing/DE/VRR/Route.pm @@ -56,7 +56,7 @@ point to another. It holds a bunch of Travel::Routing::DE::VRR::Route::Part(3pm objects describing the parts of the route in detail. Each part depends on the previous one. -You usually want to acces it via C<< $efa->routes() >>. +You usually want to acces it via C<< $efa->routes >>. =head1 METHODS @@ -67,7 +67,7 @@ You usually want to acces it via C<< $efa->routes() >>. Creates a new Travel::Routing::DE::VRR::Route elements consisting of I, which are Travel::Routing::DE::VRR::Route::Part elements. -=item $route->parts() +=item $route->parts Returns a list of Travel::Routing::DE::VRR::Route::Part(3pm) elements describing the actual route. -- cgit v1.2.3