From 7bbb014105a9e90d3da12f85241be1712e8e2c85 Mon Sep 17 00:00:00 2001
From: Birte Kristina Friesel <derf@finalrewind.org>
Date: Sun, 16 Nov 2025 12:48:14 +0100
Subject: Fix operator / train_no logic. Was storing max rather than argmax.

See #9
---
 lib/Travel/Status/DE/DBRIS/Journey.pm | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

(limited to 'lib')

diff --git a/lib/Travel/Status/DE/DBRIS/Journey.pm b/lib/Travel/Status/DE/DBRIS/Journey.pm
index 77847f5..79da609 100644
--- a/lib/Travel/Status/DE/DBRIS/Journey.pm
+++ b/lib/Travel/Status/DE/DBRIS/Journey.pm
@@ -51,17 +51,15 @@ sub new {
 			my @admin_id_argmax
 			  = reverse sort { $admin_id_ml{$a} <=> $admin_id_ml{$b} }
 			  keys %admin_id_ml;
-			if ( defined( my $admin_id = $admin_id_ml{ $admin_id_argmax[0] } ) )
+			$ref->{admin_id} = $admin_id_argmax[0];
+			if (
+				my $op
+				= Travel::Status::DE::DBRIS::Operators::get_operator_name(
+					$ref->{admin_id}
+				)
+			  )
 			{
-				$ref->{admin_id} = $admin_id;
-				if (
-					my $op
-					= Travel::Status::DE::DBRIS::Operators::get_operator_name(
-						$admin_id)
-				  )
-				{
-					$ref->{operator} = $admin_id;
-				}
+				$ref->{operator} = $op;
 			}
 
 			# return most frequent admin ID first
@@ -78,9 +76,7 @@ sub new {
 			my @trip_no_argmax
 			  = reverse sort { $trip_no_ml{$a} <=> $trip_no_ml{$b} }
 			  keys %trip_no_ml;
-			if ( defined( my $trip_no = $trip_no_ml{ $trip_no_argmax[0] } ) ) {
-				$ref->{train_no_no} = $trip_no;
-			}
+			$ref->{train_no} = $trip_no_argmax[0];
 		}
 	}
 
-- 
cgit v1.2.3