From 33dcf576a463ffacdec28fbb2484ec2e1e27b402 Mon Sep 17 00:00:00 2001
From: Daniel Friesel <derf@finalrewind.org>
Date: Wed, 28 Oct 2015 11:28:25 +0100
Subject: more constructor tests

---
 t/20-aseag.t | 92 +++++++++++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 75 insertions(+), 17 deletions(-)

diff --git a/t/20-aseag.t b/t/20-aseag.t
index d53f6c0..cf9cde3 100644
--- a/t/20-aseag.t
+++ b/t/20-aseag.t
@@ -6,17 +6,51 @@ use utf8;
 
 use Encode qw(decode);
 use List::Util qw(first);
-use Test::More tests => 14;
+use Test::More tests => 23;
+use Test::Fatal;
 
 BEGIN {
 	use_ok('Travel::Status::DE::URA');
 }
 require_ok('Travel::Status::DE::URA');
 
-my $s      = Travel::Status::DE::URA->new(
-	ura_base  => 'file:t/in',
+like(
+	exception {
+		Travel::Status::DE::URA->new( ura_base => 'file:t/in' );
+	},
+	qr{ura_base and ura_version are mandatory},
+	'ura_base / ura_version are mandatory'
+);
+
+like(
+	exception {
+		Travel::Status::DE::URA->new( ura_version => 1 );
+	},
+	qr{ura_base and ura_version are mandatory},
+	'ura_base / ura_version are mandatory'
+);
+
+like(
+	exception { Travel::Status::DE::URA->new() },
+	qr{ura_base and ura_version are mandatory},
+	'ura_base / ura_version are mandatory'
+);
+
+is(
+	exception {
+		Travel::Status::DE::URA->new(
+			ura_base    => 'file:t/in',
+			ura_version => 1
+		);
+	},
+	undef,
+	'ura_base / ura_version are the only mandatory args'
+);
+
+my $s = Travel::Status::DE::URA->new(
+	ura_base    => 'file:t/nope',
 	ura_version => 1,
-	datetime  => DateTime->new(
+	datetime    => DateTime->new(
 		year      => 2013,
 		month     => 12,
 		day       => 24,
@@ -27,8 +61,26 @@ my $s      = Travel::Status::DE::URA->new(
 	hide_past => 0
 );
 
-isa_ok( $s,                          'Travel::Status::DE::URA' );
+isa_ok( $s, 'Travel::Status::DE::URA' );
+can_ok( $s, qw(errstr results) );
+like( $s->errstr, qr{404}, 'errstr is set' );
+is_deeply( [ $s->results ], [], 'no results' );
 
+$s = Travel::Status::DE::URA->new(
+	ura_base    => 'file:t/in',
+	ura_version => 1,
+	datetime    => DateTime->new(
+		year      => 2013,
+		month     => 12,
+		day       => 24,
+		hour      => 12,
+		minute    => 42,
+		time_zone => 'Europe/Berlin'
+	),
+	hide_past => 0
+);
+
+isa_ok( $s, 'Travel::Status::DE::URA' );
 can_ok( $s, qw(errstr results) );
 
 is( $s->errstr, undef, 'errstr is not set' );
@@ -40,36 +92,42 @@ is( @results, 16208, 'All departures parsed and returned' );
 
 # results are sorted by time
 my $prev = $results[0];
-my $ok = 1;
-for my $i (1 .. $#results) {
+my $ok   = 1;
+for my $i ( 1 .. $#results ) {
 	my $cur = $results[$i];
-	if ($prev->datetime->epoch > $cur->datetime->epoch) {
+	if ( $prev->datetime->epoch > $cur->datetime->epoch ) {
 		$ok = 0;
 		last;
 	}
 }
-ok($ok, 'Results are ordered by departure');
+ok( $ok, 'Results are ordered by departure' );
 
 # hide_past => 1 should return nothing
 
-@results = $s->results( hide_past => 1 );
-is( @results, 0, 'hide_past => 1 returns nothing' );
+my $s2 = Travel::Status::DE::URA->new(
+	ura_base    => 'file:t/in',
+	ura_version => 1,
+	hide_past   => 1
+);
+is_deeply( [ $s->results( hide_past => 1 ) ],
+	[], 'hide_past => 1 returns nothing' );
+is_deeply( [ $s2->results ], [], 'hide_past => 1 returns nothing ' );
 
 # exact matching: bushof should match nothing
 
 @results = $s->results(
-	stop  => 'bushof',
+	stop => 'bushof',
 );
 is( @results, 0, '"bushof" matches nothing' );
 
 @results = $s->results(
-	stop  => 'aachen bushof',
+	stop => 'aachen bushof',
 );
 is( @results, 0, 'matching is case-sensitive' );
 
 # exact matching: Aachen Bushof should work
 @results = $s->results(
-	stop  => 'Aachen Bushof',
+	stop => 'Aachen Bushof',
 );
 
 is( @results, 375, '"Aachen Bushof" matches 375 stops' );
@@ -78,9 +136,9 @@ is( ( first { $_->stop ne 'Aachen Bushof' } @results ),
 
 # exact matching: also works in constructor
 $s = Travel::Status::DE::URA->new(
-	ura_base  => 'file:t/in',
+	ura_base    => 'file:t/in',
 	ura_version => 1,
-	datetime  => DateTime->new(
+	datetime    => DateTime->new(
 		year      => 2013,
 		month     => 12,
 		day       => 23,
@@ -92,7 +150,7 @@ $s = Travel::Status::DE::URA->new(
 	stop      => 'Aachen Bushof',
 );
 @results = $s->results(
-	stop  => 'Aachen Bushof',
+	stop => 'Aachen Bushof',
 );
 is( @results, 375, '"Aachen Bushof" matches 375 stops in constructor' );
 is( ( first { $_->stop ne 'Aachen Bushof' } @results ),
-- 
cgit v1.2.3