From 97ea33ec84ab05d8c2ac1cf669d90f3d81b835f4 Mon Sep 17 00:00:00 2001 From: Daniel Friesel Date: Fri, 4 Mar 2011 17:13:18 +0100 Subject: App::Dthumb::Data get: Return undef for invalid files --- lib/App/Dthumb/Data.pm.PL | 5 +++-- t/29-app-dthumb-data.t | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/App/Dthumb/Data.pm.PL b/lib/App/Dthumb/Data.pm.PL index 6ebea05..eaf914e 100644 --- a/lib/App/Dthumb/Data.pm.PL +++ b/lib/App/Dthumb/Data.pm.PL @@ -123,7 +123,8 @@ sub list_archived { =head2 get($filename) -Returns the exact content of share/$filename. +Returns the exact content of share/$filename (undef if no such file was +saved). =cut @@ -133,7 +134,7 @@ sub get { my $data = $self->section_data($name); if (not $data) { - die("No such data: ${name}\n"); + return undef; } $data = ${$data}; diff --git a/t/29-app-dthumb-data.t b/t/29-app-dthumb-data.t index 42e9b41..7ca9f2d 100755 --- a/t/29-app-dthumb-data.t +++ b/t/29-app-dthumb-data.t @@ -12,7 +12,7 @@ my @files = grep { /^[^.]/ } readdir($share); closedir($share); plan( - tests => 1 + scalar @files, + tests => 2 + scalar @files, ); my $dthumb = App::Dthumb::Data->new(); @@ -26,3 +26,5 @@ for my $file (@files) { is($dthumb->get($file), $data, "\$dthumb->get($file)"); } + +is($dthumb->get('404notfound'), undef, '$dthumb->get on non-existing file'); -- cgit v1.2.3