From a9850d073e5d2380deb9c69bdfbdd29e1a6fba12 Mon Sep 17 00:00:00 2001 From: Daniel Friesel Date: Sat, 14 Sep 2019 12:27:36 +0200 Subject: improve connection detection heuristic --- lib/Travelynx/Controller/Passengerrights.pm | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/Travelynx/Controller/Passengerrights.pm b/lib/Travelynx/Controller/Passengerrights.pm index 1188e19..be1ab19 100644 --- a/lib/Travelynx/Controller/Passengerrights.pm +++ b/lib/Travelynx/Controller/Passengerrights.pm @@ -13,8 +13,28 @@ sub mark_if_missed_connection { my $wait_time = ( $next_journey->{rt_departure}->epoch - $journey->{rt_arrival}->epoch ) / 60; + + + # Assumption: $next_journey is a missed connection (i.e., if $journey had + # been on time it would have been an earlier train) + # * the wait time between arrival and departure is less than 70 minutes + # (up to 60 minutes to wait for the next train in an hourly connection + # + up to 10 minutes transfer time between platforms) + # * the delay between scheduled arrival at the interchange station and + # real departure of $next_journey (which is hopefully the same as the + # total delay at the destination of $next_journey) is more than 120 + # minutes (-> 50% fare reduction) or it is more than 60 minutes and the + # single-journey delay is less than 60 minutes (-> 25% fare reduction) + # This ensures that $next_journey is only referenced if the missed + # connection makes a difference from a passenger rights point of view -- + # if $journey itself is already 60 .. 119 minutes delayed and the + # delay with the connection to $next_journey is also 60 .. 119 minutes, + # including it is not worth the effort. Similarly, if $journey is already + # ≥120 minutes delayed, looking for connections and more delay is + # pointless. + if ( - $wait_time < 120 + $wait_time < 70 and ( $possible_delay >= 120 or ( $journey->{delay} < 60 and $possible_delay >= 60 ) ) ) -- cgit v1.2.3