diff options
| author | Daniel Friesel <derf@finalrewind.org> | 2011-05-11 01:52:34 +0200 |
|---|---|---|
| committer | Daniel Friesel <derf@finalrewind.org> | 2011-05-11 01:52:34 +0200 |
| commit | eb6566cf9d1887cc5f18df58be6651579404fed4 (patch) | |
| tree | 06f676ab64b82ac65c7ad279060ffa3c4ecdfde3 /ChangeLog | |
| parent | 3be31437fe3493fe013659290744f590d1e23f9c (diff) | |
feh_parse_options_from_string: allocate argv list on stack
This fixes a really weird bug where continued theme definitions containing
just one option/value pair caused feh to mis-parse parts of the following
line.
Apparently, subsequent realloc calls mixed with strdups in another function
caused parts of the list (argv) content to be overwritten by the content of
the list pointer itself. I wasn't able to find out the exact causes /
conditions.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -31,6 +31,9 @@ git HEAD and not just the default for new windows * The zoom_default key now works fine with --scale-down <http://github.com/derf/feh/issues/41> + * Fix access of uninitialized memory / malloc/realloc clash in continued + theme definition handling. Having a theme line with just one + option/value pair used to produce undefined behaviour Sat, 23 Apr 2011 22:00:27 +0200 Daniel Friesel <derf@finalrewind.org> |