summaryrefslogtreecommitdiff
path: root/src/slideshow.c
diff options
context:
space:
mode:
authorDaniel Friesel <derf@finalrewind.org>2018-10-17 20:40:17 +0200
committerDaniel Friesel <derf@finalrewind.org>2018-10-17 20:40:17 +0200
commit9803fc41e8e6a820634f41d2196bdced7cbbc99f (patch)
tree593f59640ebe9d8eef90e3ddf8988dc7d714690c /src/slideshow.c
parenta9d46da64d02561bf2f545b3271575b304eda913 (diff)
Use random() instead of rand() to increase portability
Quoting glibc rand(3): The versions of rand() and srand() in the Linux C Library use the same random number generator as random(3) and srandom(3), so the lower-order bits should be as random as the higher-order bits. However, on older rand() implementations, and on current implementations on different systems, the lower-order bits are much less random than the higher-order bits. Do not use this function in applications intended to be portable when good randomness is needed. (Use random(3) instead.)
Diffstat (limited to 'src/slideshow.c')
-rw-r--r--src/slideshow.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/slideshow.c b/src/slideshow.c
index 3770677..b404318 100644
--- a/src/slideshow.c
+++ b/src/slideshow.c
@@ -258,7 +258,7 @@ void slideshow_change_image(winwidget winwid, int change, int render)
case SLIDE_RAND:
if (filelist_len > 1) {
current_file = feh_list_jump(filelist, current_file, FORWARD,
- (rand() % (filelist_len - 1)) + 1);
+ (random() % (filelist_len - 1)) + 1);
change = SLIDE_NEXT;
}
break;