summaryrefslogtreecommitdiff
path: root/src/slideshow.c
AgeCommit message (Collapse)AuthorLines
2021-01-24free opt.start_list_at before NULLing itDaniel Friesel-0/+2
2021-01-09distinguish between "missing magic bytes" and "no Imlib 2 loader" errorsDaniel Friesel-1/+1
2020-12-05free accompanying EXIF data when freeing an imageDaniel Friesel-0/+12
This fixes two memory bugs that only manifest with exif=1 and long-running slideshows. * when feh loads an image, it writes exif data to file->ed. Previously, this data was never free'd, causing a memory leak on subsequent loads of the same file. * As file->ed is never free'd, the accumulated EXIF data consumes a significant amount of memory over time. with slideshow-delay = 10 and two days of runtime, feh may exceed 1 GB of memory usage. If the slideshow is so large that feh does not encounter the same image twice in this time, this is not detected as a memory leak, as each EXIF data chunk is referenced from the filelist. See <https://github.com/derf/feh/issues/553> for details. Closes #553
2020-08-28Fix segmentation fault when combining --multiwindow and --reloadDaniel Friesel-36/+43
Introduced in 3fa39154f089a6fadc1a14eb6b206e2d2875be71
2020-06-16change play/pause to playing/paused to improve UXreiseb-2/+2
2020-06-16fix indentation (all tabs)reiseb-8/+8
2020-06-16add option 'a' to show play/paused information in slideshow modereiseb-0/+8
2020-04-11update copyrightDaniel Friesel-1/+1
2020-03-30move feh_reload_image to imlib.c (next to feh_load_image)Daniel Friesel-76/+0
2019-04-05Correctly round human-readable file sizeDaniel Friesel-2/+2
Closes #463
2018-11-18--start-at: Compare basenames if exact match failedDaniel Friesel-0/+46
This more closely resembles the expected behaviour of --start-at, but may lead to mismatches if several files in the filelist have the same basename. Closes #206 Related to #372 and #420
2018-11-18Make slideshow_save_image work again when opt.output_dir is unsetDaniel Friesel-2/+7
2018-11-18Merge branch 'output-directory-for-image-saving' of ↵Daniel Friesel-3/+6
https://github.com/Ferada/feh into Ferada-output-directory-for-image-saving
2018-10-17Use random() instead of rand() to increase portabilityDaniel Friesel-1/+1
Quoting glibc rand(3): The versions of rand() and srand() in the Linux C Library use the same random number generator as random(3) and srandom(3), so the lower-order bits should be as random as the higher-order bits. However, on older rand() implementations, and on current implementations on different systems, the lower-order bits are much less random than the higher-order bits. Do not use this function in applications intended to be portable when good randomness is needed. (Use random(3) instead.)
2018-10-03Use output directory for image saving command.Olof-Joachim Frahm-3/+6
2018-08-29This will fix 'jump_last' and 'jump_first' when using no-cycleulteq-1/+3
2018-08-29Merge branch 'no-cycle' of https://github.com/ulteq/feh into ulteq-no-cycleDaniel Friesel-4/+11
2018-08-24combine --no-cycle and --cycle-once into --on-last-slide={quit,hold}Daniel Friesel-5/+5
2018-08-24Add --no-cycle optionulteq-0/+7
Closes: #124
2018-08-18Prevent the premature abort of the automatic-slideshow if only one image is ↵ulteq-2/+3
there Fixes: #415
2018-06-27Merge branch 'simplify-zoom' of https://github.com/ulteq/feh into ↵Daniel Friesel-45/+2
ulteq-simplify-zoom
2018-05-11Update copyright noticeDaniel Friesel-1/+1
2018-04-04Add %g and %Z format specifiers (closes #391)Daniel Friesel-0/+12
2018-03-10Simplify --keep-zoom-vp handlingulteq-37/+0
2018-03-10Fix window auto-resize with --keep-zoom-vp enabledulteq-8/+2
--keep-zoom-vp will no longer block the dynamic window resizing mechanism.
2018-02-28Merge branch 'fix-no-files-found-on-reload' of https://github.com/Ferada/feh ↵Daniel Friesel-0/+4
into Ferada-fix-no-files-found-on-reload
2018-02-25Fix segfault when using %m format specifier in slideshow modeDaniel Friesel-1/+1
Closes: #382, #384
2018-02-14Only check image dimensions on the fly in multiwindow and slideshow modeDaniel Friesel-8/+6
This introduces a new feh_should_ignore_image function which is called at appropriate places in those modes to skip images which are loadable but undesired.
2018-02-14Merge branch 'dimension-pruning-without-preload' of ↵Daniel Friesel-6/+12
https://github.com/ulteq/feh into ulteq-dimension-pruning-without-preload
2018-01-24Simplify window title generationulteq-47/+9
2018-01-19Removes unnecessary codeulteq-7/+1
Halves the start-up time of the slideshow if the title contains data from 'file->info'
2018-01-14Handle --min-dimension and --max-dimension without preloadulteq-6/+12
This will (by default) check the image dimension on-the-fly, but you can still do it beforehand by specifying the preload flag.
2018-01-03Add files from file list file on reload.Olof-Joachim Frahm-0/+4
Fixes issue 325.
2017-10-03Make shell_escape available as a generic utility functionDaniel Friesel-23/+0
2017-02-23Fix memory leak when closing images opened from thumbnail modeDaniel Friesel-0/+1
2017-01-12Pass windidget to feh_action_run, making it possible to use format specifiersANogin-2/+2
like %o and %z in slideshow actions (I would like to use this to zoom in, pan, and then use an action to crop the window to zoomed in view).
2017-01-11rewrite window title whenever the image is rendered (closes #266)Daniel Friesel-0/+2
2016-08-21reload timer: always call prepare_filelist for sorting etc (closes #200)Daniel Friesel-2/+2
2016-06-06next/priv directory: Use PATH_MAX instead of FEH_MAX_DIRNAME_LENDaniel Friesel-6/+6
2016-05-28Add prev_dir and next_dir navigation actionsguns-0/+38
Many image collections are organized by directory, so it is nice to have jump-to-adjacent-directory navigation. e.g. Given the following file hierarchy: . ├── A │   ├── 1.jpg │   ├── 2.jpg │   └── C │   ├── 1.jpg │   ├── 2.jpg │   └── 3.jpg └── B ├── 1.jpg ├── 2.jpg └── 3.jpg `feh --recursive` creates the following filelist: A/1.jpg <---- current_file A/2.jpg A/C/1.jpg A/C/2.jpg A/C/3.jpg B/1.jpg B/2.jpg B/3.jpg If we press [next_dir], we move the current_file pointer to: A/1.jpg A/2.jpg A/C/1.jpg <-- current_file A/C/2.jpg A/C/3.jpg B/1.jpg B/2.jpg B/3.jpg Pressing [next_dir] again moves the pointer to: A/1.jpg A/2.jpg A/C/1.jpg A/C/2.jpg A/C/3.jpg B/1.jpg <---- current_file B/2.jpg B/3.jpg [next_dir] now moves the pointer back to the top of the list: A/1.jpg <---- current_file A/2.jpg A/C/1.jpg A/C/2.jpg A/C/3.jpg B/1.jpg B/2.jpg B/3.jpg Pressing [prev_dir] from here moves backwards to the first image of the previous directory: A/1.jpg A/2.jpg A/C/1.jpg A/C/2.jpg A/C/3.jpg B/1.jpg <---- current_file B/2.jpg B/3.jpg When starting from an position that is not the first image of a directory, [prev_dir] moves the pointer to the first image of the current directory. These actions combine well with `--sort dirname` since all regular files in a directory will be sorted before any subdirectories, avoiding a filelist like the following: A/1.jpg A/SUBDIR/2.jpg A/SUBDIR/3.jpg A/4.jpg With `--sort dirname` that filelist becomes: A/1.jpg A/4.jpg A/SUBDIR/2.jpg A/SUBDIR/3.jpg
2015-06-26Merge pull request #185 from shiponi/masterDaniel Friesel-1/+6
slideshow: When removing last image, stay on the last image
2015-04-07fix gib_imlib_save_image_with_error_return in imported giblib codeDaniel Friesel-1/+1
2015-03-08slideshow: When removing last image, stay on the last imageLior Shiponi-1/+6
2014-08-03make all opt.verbose messages print to stderrNoah Birnel-1/+1
manually changed in collage, imlib, filelist, thumbnail, slideshow, index feh_display_status also changed
2014-05-11feh_printf: Fix buffer overflow when handling unknown format specifiersDaniel Friesel-1/+2
2014-05-06Fix dead code found by LLVM's scan-build utilityDaniel Friesel-1/+1
2014-04-10re-randomize after list is throughRoland Angerer-1/+7
2013-05-31fix some clang warningsDaniel Friesel-22/+22
2013-05-09fix feh_printf buffer overflowsDaniel Friesel-24/+24
2013-05-06Add %L format code (temporary copy of filelist)David Gowers-0/+13