summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorLines
2011-09-01feh_reload_image: Try to reload unloadable (still existing) images ad infinitumDaniel Friesel-4/+5
This commit removes the feh_file_remove_from_list call from feh_reload_image. We can safely do this because if the file itself was removed, cb_reload_timer will take care of updating the filelist, and in all other cases it is intended to leave the image in the filelist and retry. A warning will be displayed in the image if the reload failed.
2011-09-01Revert "feh_reload_image: Always die if reload failed"Daniel Friesel-16/+26
This reverts commit 8b79bc33f37db12cbb672bdb47dcfeb0f2030bce.
2011-08-31feh_reload_image: Always die if reload failedDaniel Friesel-26/+16
This fixes a segfault in --reload when the image becomes unloadable while feh is running. Note that this does not affect --reload with more than one file: If the current image is removed, feh will simply jump to the next image. feh will only quit if the file still exists, but can no longer be loaded.
2011-08-30winwidget.c: create_window: Remove useless use of ternary operatorDaniel Friesel-1/+1
2011-08-30winwidget.c: resize: Fix non-fulllscreen Xinerama issues on screens =! 1 ↵Daniel Friesel-22/+23
(see #5)
2011-08-29winwidget.c: resize: Respect max width/height set by Xinerama (see #5)Daniel Friesel-2/+12
This fixes half of the issue - windows on Xinerama screen 0 no longer become too large, but the bug still appears on the other screens (unless XINERAMA_SCREEN is set)
2011-08-29Various code fixupsDaniel Friesel-15/+4
* remove unused variable Im1 in filelist.c * options are initialised as 0, so only explicitly set those to 0 for which it makes sense because of their context * Make a few warnings about wrong option combinations fatal
2011-08-26Minor documentation fixupDaniel Friesel-0/+1
2011-08-24--filelist: Support reading from /dev/stdin ("-" as shortcut)Daniel Friesel-15/+5
Note that read_filelist used to check if its argument was an image (for people accidentaly typing "feh -df *" instead of "feh -dF *"); this was removed because it failed on /dev/stdin. I might re-add it, but I'm not yet sure about the future of feh's automatic filelist saving.
2011-08-23imlib.c: feh_draw_info: Fix overlay image dimensions (for --draw-tinted)Daniel Friesel-24/+37
feh_draw_info used to iterate line-wise over the info output, but now we need to cache it somewhere to get the length of the longest line.
2011-08-23Fix default zoom behaviourDaniel Friesel-1/+1
67e41d607413d8e95124b1d28b6ae74924e74ab9 moved the ZOOM_MODE from options.h defines to a feh.h enum, but did not set the values correctly.
2011-08-23Deprecate the --collage option (aka collage mode)Daniel Friesel-1/+3
It is pretty random and I doubt anyone actually uses it. Also, after removing it, there are only two duplicates of the image index code instead of three...
2011-08-23imlib.c: feh_draw_info: Fix info box offsetsDaniel Friesel-2/+2
The info text used to be located 2px away from the bottom / left edges. Now that --draw-tinted has been implemented, that leaves us with an ugly edge, so move it directly to the edge.
2011-08-23Add --draw-tinted option to draw overlay text on a semi-transparent ↵Daniel Friesel-40/+32
background (closes #60, #61) By default, feh draws white text with a black drop-shadow, which is well readable in most, but not all cases. The --draw-tinted option draws a semi-transparent black box around all texts. This improves readability, but does not look as nice, so it won't become default behaviour. It was suggested to use #7f7f7f7f for the background, but I decided that for small images surrounded by a black border.
2011-08-18imlib.c: feh_draw_info: Only kill a line's last character if it's a newlineDaniel Friesel-1/+3
feh_draw_info used to unconditionally swallow the last character of a line, assuming that it must be a newline. However, the very last line of a program's output may not end in a newline, in which case its last output character was omitted.
2011-08-18--action: Reload image if hold_action flag (;) is set (closes #59)Daniel Friesel-3/+8
An action may be used to alter the image or specific parts of it displayed by --info, so if a user invokes an action with hold_action set, the image and all relevant information must be reloaded.
2011-08-16events.c: Fix recent fix for thumbnail window (closes #58)Daniel Friesel-2/+2
2011-08-15Fix some compiler warningsDaniel Friesel-7/+9
2011-08-15Convert C++ style comments to /* */Daniel Friesel-6/+7
2011-08-15slideshow.c: Make --reload properly handle --geometry/--fullscreen (closes #57)Daniel Friesel-1/+1
2011-08-13Add reload functionality for directories (derf#14)Yu-Jie Lin-0/+47
2011-08-11Disable blur/rotation in thumbnail viewerDaniel Friesel-0/+2
2011-08-11Show correct file number after deleting imageDaniel Friesel-22/+24
In the image_remove function, slideshow_change_image needs to be called before removing the image from the filelist. Because of this, the "x of y" displayed by --draw-filename is wrong (y is 1 too high). This commit introduces a new 'render' argument to slideshow_chingae_image. The image_remove function calls it with render=0, edits the filelist and then runs by winwidget_render_image itself. Patch by Yu-Jie Lin.
2011-08-11keyevents.c: Do not force aliasing when using scroll_*_pageDaniel Friesel-4/+4
2011-08-10Remove unused variablesDaniel Friesel-15/+6
2011-08-10slideshow.c: save_image: Fix handling of capital file endings (closes #51)Daniel Friesel-1/+8
gib_imlib_save_image_with_error_return was used, but it tries to set the Imlib image format by examining the filename to save to. However, it only supports lowercase file endings (as in .jpg) and breaks with others (like .JPG). Since giblib is unmaintained, for now the fix is only used here.
2011-08-09Add documentation and default keybindings for flip/mirrorDaniel Friesel-0/+2
2011-08-09Merge patch by livibetter: Add flip and mirror in-place edit actions (closes ↵Daniel Friesel-19/+51
#53)
2011-08-09Add flip/mirror in-placec edit actions (derf/#9)Yu-Jie Lin-17/+49
2011-08-02keyevents.c: Support Shift modifier (see github issue #30, patch by Yu-Jie Lin)Daniel Friesel-1/+9
2011-08-01options.c: Fix getopt/optind handling (closes #49, patch by Yu-Jie Lin)Daniel Friesel-1/+1
2011-07-31allow multiple modifierYu-Jie Lin-7/+7
Signed-off-by: Yu-Jie Lin <livibetter@gmail.com>
2011-07-31add scroll by a page actionsYu-Jie Lin-0/+32
A page is the window width or height. Signed-off-by: Yu-Jie Lin <livibetter@gmail.com>
2011-07-20Make --image-bg white work in full-screen modeDaniel Friesel-1/+4
2011-06-07Add toggle_info key (closes #48)Daniel Friesel-2/+12
2011-06-06Respect --zoom 100 in --fullscreen mode (closes #47)Daniel Friesel-4/+6
2011-05-31Fix --draw-filename "x of y" being cut off by short filenames (closes #45)Daniel Friesel-12/+20
2011-05-23filelist.c: Fix memleak in add_file_to_filelist_recursively scandir callDaniel Friesel-1/+1
2011-05-19Remove debug printf. Duh.Daniel Friesel-1/+0
2011-05-19Fix typing issue in winwidget_center_imageDaniel Friesel-2/+3
2011-05-12imlib.c: Do not include curl.h unless we use libcurlDaniel Friesel-0/+3
2011-05-11feh_parse_options_from_string: Make sure not to write beyond array boundariesDaniel Friesel-0/+5
2011-05-11feh_parse_options_from_string: allocate argv list on stackDaniel Friesel-8/+2
This fixes a really weird bug where continued theme definitions containing just one option/value pair caused feh to mis-parse parts of the following line. Apparently, subsequent realloc calls mixed with strdups in another function caused parts of the list (argv) content to be overwritten by the content of the list pointer itself. I wasn't able to find out the exact causes / conditions.
2011-05-10Respect thumbnail selection keys only in thumbnail listDaniel Friesel-5/+5
2011-05-10Fix zoom_default with --scale-down (closes #41)Daniel Friesel-2/+7
2011-05-10keyevents.c: Make toggle_aliasing actually affect the current windowDaniel Friesel-1/+2
2011-05-10winwidget.c: Set _NET_WM_NAME and _NET_WM_ICON_NAME, marked as utf8 (closes #44)Daniel Friesel-1/+10
Note that feh does not try to convert encodings or anything. It expects filenames to be in UTF8 and passe them on to NET_WM_NAME and NET_WM_ICON NAME. The only new thing is that it now also sets _NET_WM_NAME and _NET_WM_ICON_NAME and explicitly tells X11 that they are in UTF-8. Again, no recode, if you use UTF-8 filesystems (which you should), everything is fine.
2011-05-09Fix --zoom max/fill documentation plus bug in menu code (thx nepraith)Daniel Friesel-2/+3
2011-05-03winwidget_resize: Fix typoDaniel Friesel-1/+1
2011-05-03winwidget_resize: Only use netwm-fullscreen patch for fullscreen windowsDaniel Friesel-1/+16