Fix map reloading sending malformed query parameters

This patch fixes the periodic map reloading function
sending malformed query parameters, see below:

- `dbris`
- `amp;efa`
- `amp;hafas`

The function now constructs a URLSearchParams object
and appends the serialized parameters to the url instead
of using manual string concatenation.

This would break reloads only for EFA and non ÖBB HAFAS
backends, as the `dbris` parameter was working properly
malformed and ÖBB HAFAS is the default codepath.

1 files changed, 7 insertions, 1 deletions

diff --git a/public/static/js/map-refresh.js b/public/static/js/map-refresh.js
index 6dbbde5..ec7c321 100644
--- a/public/static/js/map-refresh.js
+++ b/public/static/js/map-refresh.js
@@ -69,7 +69,13 @@ function dbf_anim_fine() {
 
 function dbf_map_reload() {
 	const param = new URLSearchParams(window.location.search);
-	$.get('/_ajax_mapinfo/' + j_reqid + '?dbris=' + (param.get('dbris') || '') + '&efa=' + (param.get('efa') || '') + '&hafas=' + (param.get('hafas') || ''), function(data) {
+
+	const new_params = new URLSearchParams();
+	new_params.set('dbris', param.get('dbris') ?? '');
+	new_params.set('efa', param.get('efa') ?? '');
+	new_params.set('hafas', param.get('hafas') ?? '');
+
+	$.get('/_ajax_mapinfo/' + j_reqid + '?' + new_params.toString(), function(data) {
 		$('#infobox').html(data);
 		dbf_map_parse();
 		setTimeout(dbf_map_reload, 61000);