|author||Daniel Friesel <firstname.lastname@example.org>||2010-06-24 15:24:16 +0200|
|committer||Daniel Friesel <email@example.com>||2010-06-24 15:24:16 +0200|
Disable filelist saving from thumbnail mode (buggy and probably not useful)
4 files changed, 10 insertions, 5 deletions
@@ -8,6 +8,9 @@ git HEAD
* Rename --screen-clip 0 to --no-screen-clip
* Allow multiline theme definitions (via backslash, like in the shell)
* Center the image after pressing <keypad /> or <keypad *>
+ * Saving the filelist from thumbnail mode caused undefined behaviour due
+ to handling of uninitialised memory. Since I consider this a rarely
+ useful action, the feature has been disabled for thumbnail mode.
Thu Jun 10 12:12:04 CEST 2010
@@ -24,8 +24,8 @@ A workaround (--thumb-redraw) exists, but at some point a rewrite with a
GUI-toolkit or similar (or maybe writing a completely new tool for that and
removing the feature from feh) would be due.
-Saving the filelist from thumbnail mode will access uninitialized memory if a
-file was removed from the filelist.
+Saving the filelist from thumbnail mode is not possible. I wonder if this
+matters enough to be fixed.
Maybe: Zoom mode like --bg-fill?
@@ -753,8 +753,6 @@ available or use the builtin HTTP client
Xinerama support does not really work on Xinerama screens != 0.
-Saving the filelist after editing it from thumbnail mode does not work.
If you find a bug, please report it to
diff --git a/src/keyevents.c b/src/keyevents.c
index aa18d02..8937e91 100644
@@ -336,7 +336,11 @@ void feh_event_handle_keypress(XEvent * ev)
+ if ((winwid->type == WIN_TYPE_THUMBNAIL)
+ || (winwid->type == WIN_TYPE_THUMBNAIL_VIEWER))
+ weprintf("Filelist saving is not supported in thumbnail mode\n");