1 files changed, 65 insertions, 40 deletions

diff --git a/lib/Travelynx/Model/InTransit.pm b/lib/Travelynx/Model/InTransit.pm
index 69026ac..0d548c3 100644
--- a/lib/Travelynx/Model/InTransit.pm
+++ b/lib/Travelynx/Model/InTransit.pm
@@ -47,6 +47,16 @@ sub epoch_to_dt {
 	);
 }
 
+sub epoch_or_dt_to_dt {
+	my ($input) = @_;
+
+	if ( ref($input) eq 'DateTime' ) {
+		return $input;
+	}
+
+	return epoch_to_dt($input);
+}
+
 sub new {
 	my ( $class, %opt ) = @_;
 
@@ -211,8 +221,15 @@ sub postprocess {
 		if ($is_after) {
 			push( @route_after, $station );
 		}
-		if (    $ret->{dep_name}
-			and $station->[0] eq $ret->{dep_name} )
+
+		# Note that the departure stop may be present more than once in @route,
+		# e.g. when traveling along ring lines such as S41 / S42 in Berlin.
+		if (
+			    $ret->{dep_name}
+			and $station->[0] eq $ret->{dep_name}
+			and not($station->[2]{sched_dep}
+				and $station->[2]{sched_dep} < $ret->{sched_dep_ts} )
+		  )
 		{
 			$is_after = 1;
 			if ( @{$station} > 1 and not $dep_info ) {
@@ -273,31 +290,25 @@ sub postprocess {
 			# station is present several times in a train's route, e.g.
 			# for Frankfurt Flughafen in some nightly connections.
 			my $times = $station->[2] // {};
-			if ( $times->{sched_arr}
-				and ref( $times->{sched_arr} ) ne 'DateTime' )
-			{
-				$times->{sched_arr}
-				  = epoch_to_dt( $times->{sched_arr} );
-				if ( $times->{rt_arr} ) {
-					$times->{rt_arr}
-					  = epoch_to_dt( $times->{rt_arr} );
-					$times->{arr_delay}
-					  = $times->{rt_arr}->epoch - $times->{sched_arr}->epoch;
+			for my $key (qw(sched_arr rt_arr sched_dep rt_dep)) {
+				if ( $times->{$key} ) {
+					$times->{$key}
+					  = epoch_or_dt_to_dt( $times->{$key} );
 				}
+			}
+			if ( $times->{sched_arr} and $times->{rt_arr} ) {
+				$times->{arr_delay}
+				  = $times->{rt_arr}->epoch - $times->{sched_arr}->epoch;
+			}
+			if ( $times->{sched_arr} or $times->{rt_arr} ) {
 				$times->{arr} = $times->{rt_arr} || $times->{sched_arr};
 				$times->{arr_countdown} = $times->{arr}->epoch - $epoch;
 			}
-			if ( $times->{sched_dep}
-				and ref( $times->{sched_dep} ) ne 'DateTime' )
-			{
-				$times->{sched_dep}
-				  = epoch_to_dt( $times->{sched_dep} );
-				if ( $times->{rt_dep} ) {
-					$times->{rt_dep}
-					  = epoch_to_dt( $times->{rt_dep} );
-					$times->{dep_delay}
-					  = $times->{rt_dep}->epoch - $times->{sched_dep}->epoch;
-				}
+			if ( $times->{sched_dep} and $times->{rt_dep} ) {
+				$times->{dep_delay}
+				  = $times->{rt_dep}->epoch - $times->{sched_dep}->epoch;
+			}
+			if ( $times->{sched_dep} or $times->{rt_dep} ) {
 				$times->{dep} = $times->{rt_dep} || $times->{sched_dep};
 				$times->{dep_countdown} = $times->{dep}->epoch - $epoch;
 			}
@@ -566,7 +577,8 @@ sub set_polyline {
 		$self->set_polyline_id(
 			uid         => $uid,
 			db          => $db,
-			polyline_id => $polyline_id
+			polyline_id => $polyline_id,
+			train_id    => $opt{train_id},
 		);
 	}
 
@@ -579,11 +591,13 @@ sub set_polyline_id {
 	my $db          = $opt{db} // $self->{pg}->db;
 	my $polyline_id = $opt{polyline_id};
 
-	$db->update(
-		'in_transit',
-		{ polyline_id => $polyline_id },
-		{ user_id     => $uid }
-	);
+	my %where = ( user_id => $uid );
+
+	if ( $opt{train_id} ) {
+		$where{train_id} = $opt{train_id};
+	}
+
+	$db->update( 'in_transit', { polyline_id => $polyline_id }, \%where );
 }
 
 sub set_route_data {
@@ -596,6 +610,12 @@ sub set_route_data {
 	my $qos_msg   = $opt{qos_messages};
 	my $him_msg   = $opt{him_messages};
 
+	my %where = ( user_id => $uid );
+
+	if ( $opt{train_id} ) {
+		$where{train_id} = $opt{train_id};
+	}
+
 	my $res_h = $db->select( 'in_transit', ['data'], { user_id => $uid } )
 	  ->expand->hash;
 
@@ -612,7 +632,7 @@ sub set_route_data {
 			route => JSON->new->encode($route),
 			data  => JSON->new->encode($data)
 		},
-		{ user_id => $uid }
+		\%where
 	);
 }
 
@@ -839,6 +859,12 @@ sub update_data {
 	my $db       = $opt{db}   // $self->{pg}->db;
 	my $new_data = $opt{data} // {};
 
+	my %where = ( user_id => $uid );
+
+	if ( $opt{train_id} ) {
+		$where{train_id} = $opt{train_id};
+	}
+
 	my $res_h = $db->select( 'in_transit', ['data'], { user_id => $uid } )
 	  ->expand->hash;
 
@@ -848,11 +874,7 @@ sub update_data {
 		$data->{$k} = $v;
 	}
 
-	$db->update(
-		'in_transit',
-		{ data    => JSON->new->encode($data) },
-		{ user_id => $uid }
-	);
+	$db->update( 'in_transit', { data => JSON->new->encode($data) }, \%where );
 }
 
 sub update_user_data {
@@ -862,6 +884,12 @@ sub update_user_data {
 	my $db       = $opt{db}        // $self->{pg}->db;
 	my $new_data = $opt{user_data} // {};
 
+	my %where = ( user_id => $uid );
+
+	if ( $opt{train_id} ) {
+		$where{train_id} = $opt{train_id};
+	}
+
 	my $res_h = $db->select( 'in_transit', ['user_data'], { user_id => $uid } )
 	  ->expand->hash;
 
@@ -871,11 +899,8 @@ sub update_user_data {
 		$data->{$k} = $v;
 	}
 
-	$db->update(
-		'in_transit',
-		{ user_data => JSON->new->encode($data) },
-		{ user_id   => $uid }
-	);
+	$db->update( 'in_transit',
+		{ user_data => JSON->new->encode($data) }, \%where );
 }
 
 sub update_visibility {